CWE-88 参数注入或修改

Improper Delimitation of Arguments in a Command ('Argument Injection')

结构: Simple

Abstraction: Base

状态: Draft

被利用可能性: unkown

基本描述

The software constructs a command to execute in another control sphere, but it does not properly ensure that the command does not have any extraneous or unintended arguments, options, or switches.

扩展描述

When creating commands using interpolation into a string, developers may assume that only the arguments/options that they specify will be processed. This especially may be the case when the programmer has encoded the command in a way that prevents separate commands from being provided maliciously, e.g. in the case of shell metacharacters. When constructing the command, the developer may use whitespace or other delimiters that are intended to separate arguments when the command. However, if an attacker can provide an untrusted input that contains argument-separating delimiters, then the resulting command will have more arguments than intended by the developer. The attacker may then be able to change the behavior of the command. Depending on the functionality indicated by the extraneous argument, this may have security-relevant consequences.

相关缺陷

  • cwe_Nature: ChildOf cwe_CWE_ID: 77 cwe_View_ID: 1000 cwe_Ordinal: Primary

  • cwe_Nature: ChildOf cwe_CWE_ID: 77 cwe_View_ID: 699 cwe_Ordinal: Primary

  • cwe_Nature: ChildOf cwe_CWE_ID: 74 cwe_View_ID: 1003 cwe_Ordinal: Primary

适用平台

Language: {'cwe_Class': 'Language-Independent', 'cwe_Prevalence': 'Undetermined'}

常见的影响

范围 影响 注释
['Confidentiality', 'Integrity', 'Availability', 'Other'] ['Execute Unauthorized Code or Commands', 'Alter Execution Logic', 'Read Application Data', 'Modify Application Data'] An attacker could include arguments that allow unintended commands or code to be executed, allow sensitive data to be read or modified or could cause other unintended behavior.

可能的缓解方案

Architecture and Design

策略: Input Validation

Understand all the potential areas where untrusted inputs can enter your software: parameters or arguments, cookies, anything read from the network, environment variables, request headers as well as content, URL components, e-mail, files, databases, and any external systems that provide data to the application. Perform input validation at well-defined interfaces.

MIT-5 Implementation

策略: Input Validation

Assume all input is malicious. Use an "accept known good" input validation strategy, i.e., use a whitelist of acceptable inputs that strictly conform to specifications. Reject any input that does not strictly conform to specifications, or transform it into something that does. When performing input validation, consider all potentially relevant properties, including length, type of input, the full range of acceptable values, missing or extra inputs, syntax, consistency across related fields, and conformance to business rules. As an example of business rule logic, "boat" may be syntactically valid because it only contains alphanumeric characters, but it is not valid if the input is only expected to contain colors such as "red" or "blue." Do not rely exclusively on looking for malicious or malformed inputs (i.e., do not rely on a blacklist). A blacklist is likely to miss at least one undesirable input, especially if the code's environment changes. This can give attackers enough room to bypass the intended validation. However, blacklists can be useful for detecting potential attacks or determining which inputs are so malformed that they should be rejected outright.

Implementation

策略:

Directly convert your input type into the expected data type, such as using a conversion function that translates a string into a number. After converting to the expected data type, ensure that the input's values fall within the expected range of allowable values and that multi-field consistencies are maintained.

Implementation

策略:

Inputs should be decoded and canonicalized to the application's current internal representation before being validated (CWE-180, CWE-181). Make sure that your application does not inadvertently decode the same input twice (CWE-174). Such errors could be used to bypass whitelist schemes by introducing dangerous inputs after they have been checked. Use libraries such as the OWASP ESAPI Canonicalization control. Consider performing repeated canonicalization until your input does not change any more. This will avoid double-decoding and similar scenarios, but it might inadvertently modify inputs that are allowed to contain properly-encoded dangerous content.

Implementation

策略:

When exchanging data between components, ensure that both components are using the same character encoding. Ensure that the proper encoding is applied at each interface. Explicitly set the encoding you are using whenever the protocol allows you to do so.

Implementation

策略:

When your application combines data from multiple sources, perform the validation after the sources have been combined. The individual data elements may pass the validation step but violate the intended restrictions after they have been combined.

Testing

策略:

Use automated static analysis tools that target this type of weakness. Many modern techniques use data flow analysis to minimize the number of false positives. This is not a perfect solution, since 100% accuracy and coverage are not feasible.

Testing

策略:

Use dynamic tools and techniques that interact with the software using large test suites with many diverse inputs, such as fuzz testing (fuzzing), robustness testing, and fault injection. The software's operation may slow down, but it should not become unstable, crash, or generate incorrect results.

示例代码

例

The following simple program accepts a filename as a command line argument and displays the contents of the file back to the user. The program is installed setuid root because it is intended for use as a learning tool to allow system administrators in-training to inspect privileged system files without giving them the ability to modify them or damage the system.

bad C

int main(int argc, char** argv) {
char cmd[CMD_MAX] = "/usr/bin/cat ";
strcat(cmd, argv[1]);
system(cmd);
}

Because the program runs with root privileges, the call to system() also executes with root privileges. If a user specifies a standard filename, the call works as expected. However, if an attacker passes a string of the form ";rm -rf /", then the call to system() fails to execute cat due to a lack of arguments and then plows on to recursively delete the contents of the root partition.

Note that if argv[1] is a very long argument, then this issue might also be subject to a buffer overflow (CWE-120).

分析过的案例

标识 说明 链接
CVE-1999-0113 Canonical Example https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-1999-0113
CVE-2001-0150 Web browser executes Telnet sessions using command line arguments that are specified by the web site, which could allow remote attackers to execute arbitrary commands. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2001-0150
CVE-2001-0667 Web browser allows remote attackers to execute commands by spawning Telnet with a log file option on the command line and writing arbitrary code into an executable file which is later executed. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2001-0667
CVE-2002-0985 Argument injection vulnerability in the mail function for PHP may allow attackers to bypass safe mode restrictions and modify command line arguments to the MTA (e.g. sendmail) possibly executing commands. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2002-0985
CVE-2003-0907 Help and Support center in windows does not properly validate HCP URLs, which allows remote attackers to execute arbitrary code via quotation marks in an "hcp://" URL. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2003-0907
CVE-2004-0121 Mail client does not sufficiently filter parameters of mailto: URLs when using them as arguments to mail executable, which allows remote attackers to execute arbitrary programs. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2004-0121
CVE-2004-0473 Web browser doesn't filter "-" when invoking various commands, allowing command-line switches to be specified. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2004-0473
CVE-2004-0480 Mail client allows remote attackers to execute arbitrary code via a URI that uses a UNC network share pathname to provide an alternate configuration file. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2004-0480
CVE-2004-0489 SSH URI handler for web browser allows remote attackers to execute arbitrary code or conduct port forwarding via the a command line option. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2004-0489
CVE-2004-0411 Web browser doesn't filter "-" when invoking various commands, allowing command-line switches to be specified. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2004-0411
CVE-2005-4699 Argument injection vulnerability in TellMe 1.2 and earlier allows remote attackers to modify command line arguments for the Whois program and obtain sensitive information via "--" style options in the q_Host parameter. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2005-4699
CVE-2006-1865 Beagle before 0.2.5 can produce certain insecure command lines to launch external helper applications while indexing, which allows attackers to execute arbitrary commands. NOTE: it is not immediately clear whether this issue involves argument injection, shell metacharacters, or other issues. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2006-1865
CVE-2006-2056 Argument injection vulnerability in Internet Explorer 6 for Windows XP SP2 allows user-assisted remote attackers to modify command line arguments to an invoked mail client via " (double quote) characters in a mailto: scheme handler, as demonstrated by launching Microsoft Outlook with an arbitrary filename as an attachment. NOTE: it is not clear whether this issue is implementation-specific or a problem in the Microsoft API. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2006-2056
CVE-2006-2057 Argument injection vulnerability in Mozilla Firefox 1.0.6 allows user-assisted remote attackers to modify command line arguments to an invoked mail client via " (double quote) characters in a mailto: scheme handler, as demonstrated by launching Microsoft Outlook with an arbitrary filename as an attachment. NOTE: it is not clear whether this issue is implementation-specific or a problem in the Microsoft API. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2006-2057
CVE-2006-2058 Argument injection vulnerability in Avant Browser 10.1 Build 17 allows user-assisted remote attackers to modify command line arguments to an invoked mail client via " (double quote) characters in a mailto: scheme handler, as demonstrated by launching Microsoft Outlook with an arbitrary filename as an attachment. NOTE: it is not clear whether this issue is implementation-specific or a problem in the Microsoft API. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2006-2058
CVE-2006-2312 Argument injection vulnerability in the URI handler in Skype 2.0..104 and 2.5..0 through 2.5.*.78 for Windows allows remote authorized attackers to download arbitrary files via a URL that contains certain command-line switches. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2006-2312
CVE-2006-3015 Argument injection vulnerability in WinSCP 3.8.1 build 328 allows remote attackers to upload or download arbitrary files via encoded spaces and double-quote characters in a scp or sftp URI. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2006-3015
CVE-2006-4692 Argument injection vulnerability in the Windows Object Packager (packager.exe) in Microsoft Windows XP SP1 and SP2 and Server 2003 SP1 and earlier allows remote user-assisted attackers to execute arbitrary commands via a crafted file with a "/" (slash) character in the filename of the Command Line property, followed by a valid file extension, which causes the command before the slash to be executed, aka "Object Packager Dialogue Spoofing Vulnerability." https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2006-4692
CVE-2006-6597 Argument injection vulnerability in HyperAccess 8.4 allows user-assisted remote attackers to execute arbitrary vbscript and commands via the /r option in a telnet:// URI, which is configured to use hawin32.exe. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2006-6597
CVE-2007-0882 Argument injection vulnerability in the telnet daemon (in.telnetd) in Solaris 10 and 11 (SunOS 5.10 and 5.11) misinterprets certain client "-f" sequences as valid requests for the login program to skip authentication, which allows remote attackers to log into certain accounts, as demonstrated by the bin account. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2007-0882
CVE-2001-1246 Language interpreter's mail function accepts another argument that is concatenated to a string used in a dangerous popen() call. Since there is no neutralization of this argument, both OS Command Injection (CWE-78) and Argument Injection (CWE-88) are possible. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2001-1246

Notes

分类映射

映射的分类名 ImNode ID Fit Mapped Node Name
PLOVER Argument Injection or Modification
CERT C Secure Coding ENV03-C Sanitize the environment when invoking external programs
CERT C Secure Coding ENV33-C Imprecise Do not call system()
CERT C Secure Coding STR02-C Sanitize data passed to complex subsystems
WASC 30 Mail Command Injection

相关攻击模式

  • CAPEC-137
  • CAPEC-174
  • CAPEC-41
  • CAPEC-460
  • CAPEC-88

引用